This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] inf-ptrace: Do not stop memory transfers after a single word
- From: Jiong Wang <jiong dot wang at foss dot arm dot com>
- To: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>, gdb-patches at sourceware dot org
- Cc: Simon Marchi <simon dot marchi at ericsson dot com>
- Date: Thu, 16 Mar 2017 10:44:34 +0000
- Subject: Re: [PATCH v2] inf-ptrace: Do not stop memory transfers after a single word
- Authentication-results: sourceware.org; auth=none
- References: <m3bmt3eucs.fsf@oc1027705133.ibm.com>
On 14/03/17 15:44, Andreas Arnez wrote:
+ /* Restrict to a chunk that fits in the current word. */
+ chunk = std::min (sizeof (PTRACE_TYPE_RET) - skip, len - n);
On 14/03/17 15:44, Andreas Arnez wrote:
+ /* Restrict to a chunk that fits in the current word. */
+ chunk = std::min (sizeof (PTRACE_TYPE_RET) - skip, len - n);
Hi Andres,
I am seeing the following build failure on my local AArch32 native build:
...binutils-gdb/gdb/inf-ptrace.c:473:65: error: no matching function for call to 'min(unsigned int, ULONGEST)'
There are a few ways to fix this, this patch simply change the type of "skip" from "unsigned int" to "ULONGEST" so operands for std::min can have the same type.
OK for master?
gdb/
2017-03-16 Jiong Wang <jiong.wang@arm.com>
* inf-ptrace.c (inf_ptrace_peek_poke): Change the type to "ULONGEST" for
"skip".
diff --git a/gdb/inf-ptrace.c b/gdb/inf-ptrace.c
index 32794ec132f72c261debd329196c73a4e3cff75b..431a36b8c726f8475650de00bf895b8d5f48fa83 100644
--- a/gdb/inf-ptrace.c
+++ b/gdb/inf-ptrace.c
@@ -462,7 +462,7 @@ inf_ptrace_peek_poke (pid_t pid, gdb_byte *readbuf,
/* We transfer aligned words. Thus align ADDR down to a word
boundary and determine how many bytes to skip at the
beginning. */
- unsigned int skip = addr & (sizeof (PTRACE_TYPE_RET) - 1);
+ ULONGEST skip = addr & (sizeof (PTRACE_TYPE_RET) - 1);
addr -= skip;
for (n = 0;