This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v1.2 1/3] Introduce gdb::function_view
On 02/23/2017 02:58 PM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>> gdb/ChangeLog:
>> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>>
>> * Makefile.in (SUBDIR_UNITTESTS_SRCS, SUBDIR_UNITTESTS_OBS): New.
>> (SFILES): Add $(SUBDIR_UNITTEST_SRCS).
>> (COMMON_OBS): Add $(SUBDIR_UNITTEST_OBS).
>> (%.o) <unittests/%.c>: New pattern.
>> (INIT_FILES): Add $(SUBDIR_UNITTESTS_SRCS).
>> * common/function-view.h: New file.
>> * unittests/function-view-selftests.c: New file.
>
> Patch is good to me. Nit, CL entry on configure.ac is missing.
Oh, I completely forgot to update the CL. Thanks for noticing.
I'll fix before pushing.
Anyone plans to review patch #3?
Thanks,
Pedro Alves