This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3] [ppc64] Add POWER8/ISA 2.07 atomic sequences single-stepping support
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: lgustavo at codesourcery dot com
- Cc: emachado at linux dot vnet dot ibm dot com (Edjunior Barbosa Machado), gdb-patches at sourceware dot org
- Date: Tue, 21 Feb 2017 11:55:25 +0100 (CET)
- Subject: Re: [PATCH v3] [ppc64] Add POWER8/ISA 2.07 atomic sequences single-stepping support
- Authentication-results: sourceware.org; auth=none
Luis Machado wrote:
> On 02/16/2017 05:42 PM, Edjunior Barbosa Machado wrote:
> > What about gdb.arch/ppc64-isa207-atomic-inst.*?
> >
>
> Could be. I don't have a better suggestion. Maybe Ulrich has.
Not really ... the name looks good to me.
> > +if {![istarget "powerpc*"] || ![is_lp64_target]} {
> > + verbose "Skipping testing of powerpc64 single stepping over atomic sequences."
>
> untested "skipping powerpc isa 207 atomic sequences test"?
Agreed, makes sense.
> Otherwise i have no further comments.
Thanks for the review, Luis!
Edjunior, the patch is OK with the above change.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com