This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/8] Rename read_unsigned_leb128 to gdb_read_unsigned_leb128


On Thu, 16 Feb 2017 16:23:51 +0100, Pedro Alves wrote:
> Can't we just use bfd's version?

bfd's version is in libbfd.c:
/* Assorted BFD support routines, only used internally.
and libbfd.h:
/* libbfd.h -- Declarations used by bfd library *implementation*.
   (This include file is not for users of the library.)

And I think GDB is a user of libbfd library.

(One could argue libbfd should use visibility and/or C++ namespaces but for
historical reasons libbfd does not use either.)

I do not mind any solution, I have just complied with the libbfd policy.


Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]