This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] [trivial] Fix test names starting with uppercase in gdb.arch/ppc64-atomic-inst.exp
On 02/06/2017 08:03 AM, Luis Machado wrote:
>> @@ -52,6 +54,18 @@ proc do_test { displaced } {
>> gdb_breakpoint "$bp2" "Breakpoint $decimal at $hex" \
>> "Set the breakpoint at the start of the ldarx/stdcx sequence"
>>
>> + set bp3 [gdb_get_line_number "lbarx"]
>> + gdb_breakpoint "$bp3" "Breakpoint $decimal at $hex" \
>> + "Set the breakpoint at the start of the lbarx/stbcx sequence"
>
> I think my previous set of testsuite fixups failed to catch these test
> names starting with uppercase. But we're requiring test names to start
> with lowercase now. I can address the rest of the offenders in a future
> patch, but new code should have the right format.
>
Hi,
this trivial patch fixes the test names starting with uppercase using gdb_test
in gdb.arch/ppc64-atomic-inst.exp.
Thanks,
--
Edjunior
gdb/testsuite/
2017-02-14 Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
* gdb.arch/ppc64-atomic-inst.exp: Fix test names starting with
uppercase.
---
gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp b/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp
index d1b3a7d..7bfff6c 100644
--- a/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp
+++ b/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp
@@ -46,23 +46,23 @@ proc do_test { displaced } {
set bp1 [gdb_get_line_number "lwarx"]
gdb_breakpoint "$bp1" "Breakpoint $decimal at $hex" \
- "Set the breakpoint at the start of the lwarx/stwcx sequence"
+ "set the breakpoint at the start of the lwarx/stwcx sequence"
set bp2 [gdb_get_line_number "ldarx"]
gdb_breakpoint "$bp2" "Breakpoint $decimal at $hex" \
- "Set the breakpoint at the start of the ldarx/stdcx sequence"
+ "set the breakpoint at the start of the ldarx/stdcx sequence"
gdb_test continue "Continuing.*Breakpoint $decimal.*" \
- "Continue until lwarx/stwcx start breakpoint"
+ "continue until lwarx/stwcx start breakpoint"
gdb_test nexti "bne.*1b" \
- "Step through the lwarx/stwcx sequence"
+ "step through the lwarx/stwcx sequence"
gdb_test continue "Continuing.*Breakpoint $decimal.*" \
- "Continue until ldarx/stdcx start breakpoint"
+ "continue until ldarx/stdcx start breakpoint"
gdb_test nexti "bne.*1b" \
- "Step through the ldarx/stdcx sequence"
+ "step through the ldarx/stdcx sequence"
}
foreach displaced { "off" "on" } {
--
1.8.3.1