Re: [PATCH 1/2] Add rdrand/rdseed record/replay tests

[Luis Machado <lgustavo at codesourcery dot com>]

On 02/01/2017 05:09 AM, Pedro Alves wrote:
> On 01/26/2017 05:18 PM, Luis Machado wrote:
>
> > +/* Fetches information from cpuid and sets flags indicating supported
> > +   features.  */
>
> What flags?

This is stale. The function should actually be called 
check_rdrand_support, so that's what it does. In my previous design it 
checked for a number of features, but i've trimmed it down.

> > +
> > +static unsigned int
> > +check_cpu_support (void)
> > +{
> > +  unsigned int rdrand_mask = (1 << 30);
> > +  unsigned int eax, ebx, ecx, edx;
> > +
> > +  __get_cpuid(1, &eax, &ebx, &ecx, &edx);

Fixed locally.