This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 5/5] Add support for Intel PKRU register to GDB and GDBserver.
- From: "Sturm, Michael" <michael dot sturm at intel dot com>
- To: Pedro Alves <palves at redhat dot com>, mark dot kettenis at xs4all dot nl, eliz at gnu dot org
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 1 Feb 2017 13:33:56 +0100
- Subject: Re: [PATCH v3 5/5] Add support for Intel PKRU register to GDB and GDBserver.
- Authentication-results: sourceware.org; auth=none
- References: <1481021894-29471-1-git-send-email-michael.sturm@intel.com> <1481021894-29471-6-git-send-email-michael.sturm@intel.com> <c160cf95-ddf6-2c62-963b-588558f6c1d2@redhat.com> <588B607A.9040507@intel.com> <8efd1e4f-47f9-8fe6-6db9-b6824970d91d@redhat.com>
On 27/01/2017 16:22, Pedro Alves wrote:
On 01/27/2017 03:00 PM, Sturm, Michael wrote:
In the test:
+#include <stdio.h>
This is not needed, right?
It's needed to pull in the definition for NULL which is used in the call
to __get_cpuid_
Ah. Could you include stddef.h instead? We avoid using stdio in tests
unless required for the specifics of the test, in order to be able to run
as most tests as possible against remote targets that don't support
remote I/O (which are most, though the local gdbserver testing boards nowadays
work around it). Just #including <stdio.h> without relying on printf etc. itself
is probably not really problematic anywhere, but it's a good proxy
for identifying tests that wouldn't/shouldn't work in such targets.
Thanks,
Pedro Alves
Yes, will do. V4 of the series with comments addressed and rebased will
be coming soon.
Thanks and Regards,
Michael
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928