This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH v4 0/9] Python bindings for btrace recordings


Hi Markus!

Applied locally. Thanks!

Tim

> -----Original Message-----
> From: Metzger, Markus T
> Sent: Friday, January 20, 2017 11:18 AM
> To: Wiederhake, Tim <tim.wiederhake@intel.com>; gdb-
> patches@sourceware.org
> Cc: Doug Evans <xdje42@gmail.com>
> Subject: RE: [PATCH v4 0/9] Python bindings for btrace recordings
> 
> > -----Original Message-----
> > From: Wiederhake, Tim
> > Sent: Wednesday, January 4, 2017 1:46 PM
> > To: gdb-patches@sourceware.org
> > Cc: Metzger, Markus T <markus.t.metzger@intel.com>
> > Subject: [PATCH v4 0/9] Python bindings for btrace recordings
> 
> Hello Tim,
> 
> > The feedback I got for V3 (thank you, Doug, Eli and Markus!) resulted
> > in the following changes:
> >  - Several small changes to documentation and comments
> >  - btrace_find_insn_by_number now does less comparisons
> >  - record_start now discrimates between "invalid method" and "invalid
> format"
> >  - Added record_stop
> >  - The tests for "full" and "btrace" recording are now split into
> > seperate files
> >  - btrace_insn_number can be called on instructions as well as on gaps
> >  - extension.{c,h} could not help me getting rid of Python in core GDB.
> >    I extended target_ops to provide the neccessary information in a
> >    Python-agnostic way.
> >  - Changed the name of the "symbol" function of Python "Instruction"
> objects to
> >    "sal".
> >  - Tried to reduce "yoda style" in "if" expressions where it would not make
> line
> >    wrapping too horrible.
> >  - And finally, I changed the copyright lines to "2016-2017"
> 
> The btrace changes look good to me.  See separate emails for comments on
> two of the patches.
> 
> I have not reviewed the Python changes again.  IIRC Doug had commented
> on them.
> 
> Thanks for the patches,
> Markus.

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]