This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/3] Use register_size () instead of MAX_REGISTER_SIZE

On 17-01-09 10:55:18, Alan Hayward wrote:
> Aarch64 SVE requires a max register size of 256. The current max size in gdb
> is 64. This is part of a series demonstrating the replacement of
> In cases where a buffer is created to hold a single register, then
> MAX_REGISTER_SIZE can be replaced with a call to register_size ().
> This patch is restricted to amd64-tdep.c, remote.c and regcache.c.
> Follow on patch sets will expand to other files.
> Tested on x86.
> Ok to commit?
> Thanks,
> Alan.

Nits on ChangeLog,

> 2017-01-09 Alan Hayward  <>

two spaces between date and name.

>     * amd64-tdep.c (amd64_pseudo_register_read_value): remove
 ^^^^^ tab rather than spaces.


	* amd64-tdep.c (amd64_pseudo_register_read_value): Use
	register_size instead of MAX_REGISTER_SIZE.

>     (amd64_pseudo_register_read_value): Likewise.
>     * remote.c (fetch_register_using_p): Remove MAX_REGISTER_SIZE.
>     (store_register_using_P): Likewise.
>     * regcache.c (regcache_xfer_part): Likewise.

otherwise, patch is good to me.

Yao (齐尧)

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]