This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 4/8] Return -1 on memory error in print_insn_msp430


On Tue, Jan 10, 2017 at 12:26:14PM +0000, Yao Qi wrote:
> 	* msp430-dis.c (msp430_singleoperand): Return -1 if
> 	msp430dis_opcode_signed returns false.
> 	(msp430_doubleoperand): Likewise.
> 	(msp430_branchinstr): Return -1 if
> 	msp430dis_opcode_unsigned returns false.
> 	(msp430x_calla_instr): Likewise.
> 	(print_insn_msp430): Likewise.

You missed nine msp430dis_opcode_signed calls.  OK with those done too.

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]