This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Assert on lval_register
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: qiyaoltc at gmail dot com (Yao Qi)
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 6 Dec 2016 14:13:28 +0100 (CET)
- Subject: Re: [PATCH] Assert on lval_register
- Authentication-results: sourceware.org; auth=none
Yao Qi wrote:
> On 16-11-30 22:16:37, Ulrich Weigand wrote:
> > I think we should simply get rid of frame_register_unwind. Callers
> > should be changed to use frame_unwind_register_value directly, and
> > just operate on the value.
>
> Yeah, that is what I was trying to do, but we should be careful on
> the value management in the end of frame_register_unwind,
>
> /* Dispose of the new value. This prevents watchpoints from
> trying to watch the saved frame pointer. */
> release_value (value);
> value_free (value);
Right. Those callers that care will need to handle this themselves.
> OK, how about the patch below?
Looks good to me.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com