This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/3] Rename some trace functions
- From: Simon Marchi <simon dot marchi at polymtl dot ca>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Thu, 01 Dec 2016 11:07:42 -0500
- Subject: Re: [PATCH 1/3] Rename some trace functions
- Authentication-results: sourceware.org; auth=none
- References: <20161013210728.18756-1-simon.marchi@ericsson.com> <15a0dc12-0649-f915-5c31-eb68a568cd59@redhat.com>
On 2016-12-01 09:21, Pedro Alves wrote:
static void trace_find_command (char *, int);
static void trace_find_pc_command (char *, int);
static void trace_find_tracepoint_command (char *, int);
Surprised you didn't do the same to "trace_find" -> "tfind" ?
Hmm indeed. And trace_dump -> tdump as well.
I'll send a v2, since there's new stuff.
Meanwhile we have C++11, so we could consider making this
an "enum class" instead. Then we could keep using
tstop_command here.
Indeed. But for this I think I prefer "trace_stop_command" over
"tstop_command" anyway.