This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] Add unit test to aarch64 prologue analyzer
- From: Pedro Alves <palves at redhat dot com>
- To: Luis Machado <lgustavo at codesourcery dot com>, Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Thu, 1 Dec 2016 12:53:28 +0000
- Subject: Re: [PATCH 1/2] Add unit test to aarch64 prologue analyzer
- Authentication-results: sourceware.org; auth=none
- References: <1480428758-2481-1-git-send-email-yao.qi@linaro.org> <55ea5ba0-6ea7-686d-1841-48875ed8587c@codesourcery.com>
On 11/30/2016 07:30 PM, Luis Machado wrote:
> Should the curly braces both be on their own lines as the rest of the
> uses? I see mixed formatting in the uses of namespace we currently have.
> We should pick one and go with it.
>
> I particularly dislike the curly brace on the same line being used to
> GNU's coding standards.
Looking at the GCC codebase, the style with trailing { on the same
line (my preferred) is prevalent:
$ grep "^namespace " gcc/* | grep "{$" | wc -l
282
$ grep "^namespace " gcc/* | grep -v "{$" | wc -l
28
That style lends itself to opening nested namespaces more
like a FQN, like:
namespace foo { namespace bar {
With C++17, we'll be able to write:
namespace foo::bar {
Thanks,
Pedro Alves