This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] gdbserver-amd64: add HAVE_STRUCT_USER_REGS_STRUCT_(GS|FS)_BASE for gdbserver.
On 11/10/2016 12:37 PM, Gary Benson wrote:
> Walfred Tedeschi wrote:
>> diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure
>> index bbce742..376ca9d 100755
>> --- a/gdb/gdbserver/configure
>> +++ b/gdb/gdbserver/configure
>> @@ -7591,6 +7591,32 @@ _ACEOF
>> fi
>>
>>
>> +# See if <sys/user.h> supports the %fs_base and %gs_bas amd64 segment registers.
>> +# Older amd64 Linux's don't have the fs_base and gs_base members of
>> +# `struct user_regs_struct'.
>
> I'd mildly prefer to see these comments wrapped at 72 columns,
There's a typo "%gs_bas" in there. It's present in gdb's configure.ac too,
where this was copied this from. With the typo fixed, the line exceeds
80 columns, so the paragraph will need to be reflowed anyway.
So OK with typo fixed and comment re-wrapped.
Thanks,
Pedro Alves