This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Remove make_cleanup_htab_delete
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Tue, 22 Nov 2016 17:02:34 +0000
- Subject: Re: [RFA] Remove make_cleanup_htab_delete
- Authentication-results: sourceware.org; auth=none
- References: <1479674269-13540-1-git-send-email-tom@tromey.com>
On 11/20/2016 08:37 PM, Tom Tromey wrote:
> This removes make_cleanup_htab_delete in favor of destructors,
> building on an earlier patch that added the htab_up typedef.
We could probably convert all of these to std::unordered_map,
but meanwhile ...
>
> 2016-11-20 Tom Tromey <tom@tromey.com>
>
> * utils.h (make_cleanup_htab_delete): Don't declare.
> * utils.c (do_htab_delete_cleanup, make_cleanup_htab_delete):
> Remove.
> * linespec.c (decode_compound_collector): Add constructor,
> destructor.
> (lookup_prefix_sym): Remove cleanup.
> (symtab_collector): Add constructor, destructor.
> (collect_symtabs_from_filename): Remove cleanup.
> * disasm.c (do_mixed_source_and_assembly): Use htab_up.
> * compile/compile-c-symbols.c (generate_c_for_variable_locations):
> Use htab_up.
> * gnu-v3-abi.c (gnuv3_print_vtable): Use htab_up.
> * dwarf2read.c (dw2_expand_symtabs_matching)
> (dw2_map_symbol_filenames, dwarf_decode_macros)
> (write_psymtabs_to_index): Use htab_up.
> * dwarf2loc.c (func_verify_no_selftailcall)
> (call_site_find_chain_1): Use htab_up.
... LGTM.
Thanks,
Pedro Alves