This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: set_value_component_location in apply_val_pretty_printer
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: user-agent at de dot ibm dot com, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Tom Tromey <tom at tromey dot com>
- Date: Mon, 21 Nov 2016 20:37:24 +0000
- Subject: Re: set_value_component_location in apply_val_pretty_printer
- Authentication-results: sourceware.org; auth=none
- References: <20161114125143.GA22037@E107787-LIN> <20161114163832.3C14F10B924@oc8523832656.ibm.com> <20161121141428.GB28605@E107787-LIN> <CAH=s-PMRLNNPzwMDMiZV1L6cqvx58u_Fk_ng9JLLbyQLQC2uOA@mail.gmail.com>
On Mon, Nov 21, 2016 at 06:23:47PM +0000, Yao Qi wrote:
> I removed the code setting VALUE_NEXT_FRAME_ID, but
> value_from_component only sets VALUE_FRAME_ID. The change
> above is not equivalent, and it causes some regressions in
> https://sourceware.org/ml/gdb-testers/2016-q4/msg03381.html
>
> Sorry about that. The fix would be setting both
> VALUE_NEXT_FRAME_ID and VALUE_FRAME_ID in
> value_from_component. I'll give a fix.
>
Oh, looks we renamed VALUE_FRAME_ID to VALUE_NEXT_FRAME_ID recently,
https://sourceware.org/ml/gdb-patches/2016-11/msg00018.html
and I regression tested against a copy of one-week-old gdb, but
didn't see the regression. The fix would be replacing VALUE_FRAME_ID
with VALUE_NEXT_FRAME_ID in my patch. Testing the fix...
--
Yao