This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 1/2] use get_frame_register_value instead of deprecated_frame_register_read
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: gdb-patches at sourceware dot org
- Date: Fri, 4 Nov 2016 17:14:50 +0000
- Subject: [PATCH 1/2] use get_frame_register_value instead of deprecated_frame_register_read
- Authentication-results: sourceware.org; auth=none
- References: <1478279691-25682-1-git-send-email-yao.qi@linaro.org>
This patch calls get_frame_register_value instead of
deprecated_frame_register_read, so that we can pass
value_contents_for_printing to val_print. Both
get_frame_register_value and deprecated_frame_register_read call
frame_unwind_register_value indirectly, so no functionality is changed
by this patch.
gdb:
2016-11-04 Yao Qi <yao.qi@linaro.org>
* mt-tdep.c (mt_registers_info): Call
get_frame_register_value instead of
deprecated_frame_register_read.
* sh64-tdep.c (sh64_do_register): Likewise.
---
gdb/mt-tdep.c | 10 +++++-----
gdb/sh64-tdep.c | 15 +++++++++------
2 files changed, 14 insertions(+), 11 deletions(-)
diff --git a/gdb/mt-tdep.c b/gdb/mt-tdep.c
index 95dd681..c08e805 100644
--- a/gdb/mt-tdep.c
+++ b/gdb/mt-tdep.c
@@ -712,11 +712,10 @@ mt_registers_info (struct gdbarch *gdbarch,
|| regnum == MT_COPRO_PSEUDOREG_REGNUM)
{
/* Special output handling for the 'coprocessor' register. */
- gdb_byte *buf;
struct value_print_options opts;
+ struct value *val;
- buf = (gdb_byte *) alloca (register_size (gdbarch, MT_COPRO_REGNUM));
- deprecated_frame_register_read (frame, MT_COPRO_REGNUM, buf);
+ val = get_frame_register_value (frame, MT_COPRO_REGNUM);
/* And print. */
regnum = MT_COPRO_PSEUDOREG_REGNUM;
fputs_filtered (gdbarch_register_name (gdbarch, regnum),
@@ -726,8 +725,9 @@ mt_registers_info (struct gdbarch *gdbarch,
file);
get_no_prettyformat_print_options (&opts);
opts.deref_ref = 1;
- val_print (register_type (gdbarch, regnum), buf,
- 0, 0, file, 0, NULL,
+ val_print (register_type (gdbarch, regnum),
+ value_contents_for_printing (val),
+ 0, 0, file, 0, val,
&opts, current_language);
fputs_filtered ("\n", file);
}
diff --git a/gdb/sh64-tdep.c b/gdb/sh64-tdep.c
index cbbefdd..9054e20 100644
--- a/gdb/sh64-tdep.c
+++ b/gdb/sh64-tdep.c
@@ -2030,15 +2030,16 @@ static void
sh64_do_register (struct gdbarch *gdbarch, struct ui_file *file,
struct frame_info *frame, int regnum)
{
- unsigned char raw_buffer[MAX_REGISTER_SIZE];
struct value_print_options opts;
+ struct value *val;
fputs_filtered (gdbarch_register_name (gdbarch, regnum), file);
print_spaces_filtered (15 - strlen (gdbarch_register_name
(gdbarch, regnum)), file);
/* Get the data in raw format. */
- if (!deprecated_frame_register_read (frame, regnum, raw_buffer))
+ val = get_frame_register_value (frame, regnum);
+ if (value_optimized_out (val) || !value_entirely_available (val))
{
fprintf_filtered (file, "*value not available*\n");
return;
@@ -2046,13 +2047,15 @@ sh64_do_register (struct gdbarch *gdbarch, struct ui_file *file,
get_formatted_print_options (&opts, 'x');
opts.deref_ref = 1;
- val_print (register_type (gdbarch, regnum), raw_buffer, 0, 0,
- file, 0, NULL, &opts, current_language);
+ val_print (register_type (gdbarch, regnum),
+ value_contents_for_printing (val), 0, 0,
+ file, 0, val, &opts, current_language);
fprintf_filtered (file, "\t");
get_formatted_print_options (&opts, 0);
opts.deref_ref = 1;
- val_print (register_type (gdbarch, regnum), raw_buffer, 0, 0,
- file, 0, NULL, &opts, current_language);
+ val_print (register_type (gdbarch, regnum),
+ value_contents_for_printing (val), 0, 0,
+ file, 0, val, &opts, current_language);
fprintf_filtered (file, "\n");
}
--
1.9.1