This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 2/2] Make some dwarf_expr_context methods pure virtual
On 10/25/2016 05:33 PM, Trevor Saunders wrote:
> On Tue, Oct 25, 2016 at 03:04:57PM +0100, Pedro Alves wrote:
>> On 10/25/2016 02:47 PM, Tom Tromey wrote:
>>>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>>>
>>> Pedro> Looks like -Wnon-virtual-dtor was removed from (guessing) -Wall
>>> Pedro> at some point.
>>>
>>> Perhaps it's worth adding it explicitly in configure.ac.
>>> (Though I don't know why it was removed from -Wall, so maybe it's not
>>> always appropriate, for reasons I don't know.)
>>
>> Yeah, cross my mind too. I'd like to understand why it was
>> removed first. (I don't know whether it used to be in -Wall, or
>> default, or enabled along some other -Wfoo option.)
>
> with g++ 6 I'm seeing -Wdelete-non-virtual-dtor enabled by -Wall, which
> seems to be warning about the same thing?
>
> oh, accept -wdelete-non-virtual-dtor looks like it wouldn't warn if the
> class is always on the stack like it is here.
Ah, nice. Sounds like we're already covered then.
Thanks,
Pedro Alves