This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix phony iconv build

From: Pedro Alves <palves at redhat dot com>
To: Tom Tromey <tom at tromey dot com>
Cc: gdb-patches at sourceware dot org
Date: Mon, 17 Oct 2016 17:04:03 +0100
Subject: Re: [PATCH] Fix phony iconv build
Authentication-results: sourceware.org; auth=none
References: <1476713788-18547-1-git-send-email-palves@redhat.com> <871szf3r0j.fsf@tromey.com>

On 10/17/2016 04:59 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
> Pedro> This is a regression caused by commit cda6c55bd399 (Turn wchar
> Pedro> iterator into a class).  The problem is that iconv_t is now exposed in
> Pedro> charset.h, while before it was only used in charset.c.  gdb/charset.c,
> Pedro> under #ifdef PHONY_ICONV, does:
> 
> I'm sorry about that.

No worries.  Seems like no build slave is exercising this
code path.

> Pedro> So it seems the simplest is to use 'int' in the header file too.
> Pedro> Tromey, WDYT?
> 
> Looks good, thanks.

Thanks, I'll push it in soon.

Thanks,
Pedro Alves

References:
- [PATCH] Fix phony iconv build
  - From: Pedro Alves
- Re: [PATCH] Fix phony iconv build
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]