This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] tilegx-tdep: Correct aliasing errors in `tilegx_analyze_prologue'
- From: "Maciej W. Rozycki" <macro at imgtec dot com>
- To: <gdb-patches at sourceware dot org>
- Date: Mon, 17 Oct 2016 16:18:06 +0100
- Subject: [PATCH] tilegx-tdep: Correct aliasing errors in `tilegx_analyze_prologue'
- Authentication-results: sourceware.org; auth=none
Fix a load of aliasing build errors:
cc1plus: warnings being treated as errors
.../gdb/tilegx-tdep.c: In function 'CORE_ADDR tilegx_analyze_prologue(gdbarch*, CORE_ADDR, CORE_ADDR, tilegx_frame_cache*, frame_info*)':
.../gdb/tilegx-tdep.c:609: error: dereferencing pointer 'operands' does break strict-aliasing rules
.../gdb/tilegx-tdep.c:592: error: dereferencing pointer 'operands' does break strict-aliasing rules
.../gdb/tilegx-tdep.c:571: error: dereferencing pointer 'operands' does break strict-aliasing rules
[...]
.../gdb/tilegx-tdep.c:601: error: dereferencing pointer '<anonymous>' does break strict-aliasing rules
.../gdb/tilegx-tdep.c:601: note: initialized from here
cc1plus: error: dereferencing pointer 'operands' does break strict-aliasing rules
cc1plus: error: dereferencing pointer 'operands' does break strict-aliasing rules
.../gdb/tilegx-tdep.c:452: note: initialized from here
cc1plus: error: dereferencing pointer 'pretmp.896' does break strict-aliasing rules
cc1plus: note: initialized from here
cc1plus: error: dereferencing pointer 'pretmp.896' does break strict-aliasing rules
cc1plus: note: initialized from here
make[1]: *** [tilegx-tdep.o] Error 1
from an attempt to cast a `long long' pointer to an `int64_t' pointer,
which may not necessarily be compatible types. Use the `long long' type
for the auxiliary variable then as this is the type of the structure
member referred.
gdb/
* tilegx-tdep.c (tilegx_analyze_prologue): Use the `long long'
type for `operands'.
---
Hi,
This was discovered in an `--enable-targets=all' `mips-mti-linux-gnu'
build and may be dependent on the host type and compiler version, which
are `x86_64-linux' and 4.4.7 here, respectively. OK to apply?
Maciej
gdb-tilegx-prologue-operands-fix.diff
Index: binutils/gdb/tilegx-tdep.c
===================================================================
--- binutils.orig/gdb/tilegx-tdep.c 2016-10-05 00:58:09.000000000 +0100
+++ binutils/gdb/tilegx-tdep.c 2016-10-15 01:29:35.689998335 +0100
@@ -449,7 +449,7 @@ tilegx_analyze_prologue (struct gdbarch*
for (i = 0; i < num_insns; i++)
{
struct tilegx_decoded_instruction *this_insn = &decoded[i];
- int64_t *operands = (int64_t *) this_insn->operand_values;
+ long long *operands = this_insn->operand_values;
const struct tilegx_opcode *opcode = this_insn->opcode;
switch (opcode->mnemonic)