Re: [PATCH] gdb.btrace/*.exp: Make test names unique

[Yao Qi <qiyaoltc at gmail dot com>]

On Mon, Oct 3, 2016 at 8:17 PM, Simon Marchi

Patch is good to me, some nits below,

>  # we can read memory if we explicitly allow it.
> -gdb_test_no_output "set record btrace replay-memory-access read-write"
> -gdb_test "print glob" "1"
> +with_test_prefix "replaying, replay-memory-access = read-write" {
> +    gdb_test_no_output "set record btrace replay-memory-access read-write"

Nit, I'd like to move this test out of with_test_prefix block, as it is unique.

> +    gdb_test "print glob" "1"
> +}
>
>  # we can't if we don't explicitly allow it.
> -gdb_test_no_output "set record btrace replay-memory-access read-only"
> -gdb_test "print glob" "unavailable\[^\\\r\\\n\]*"
> +with_test_prefix "replaying, replay-memory-access = read-only" {
> +    gdb_test_no_output "set record btrace replay-memory-access read-only"

Likewise.

> +    gdb_test "print glob" "unavailable\[^\\\r\\\n\]*"
> +}
>

> diff --git a/gdb/testsuite/gdb.btrace/delta.exp b/gdb/testsuite/gdb.btrace/delta.exp
> index c9dbf38..c822400 100644
> --- a/gdb/testsuite/gdb.btrace/delta.exp
> +++ b/gdb/testsuite/gdb.btrace/delta.exp
> @@ -47,7 +47,7 @@ with_test_prefix "no trace" {
>  }
>
>  # we record each single-step, even if we have not seen a branch, yet.
> -gdb_test "stepi"
> +gdb_test "stepi" "main\.4.*" "stepi #1"
>
>  proc check_trace {} {
>    gdb_test "info record" [multi_line \
> @@ -70,18 +70,18 @@ with_test_prefix "twice" {
>  }
>
>  # check that we can reverse-stepi that instruction
> -gdb_test "reverse-stepi"
> +gdb_test "reverse-stepi" "main\.3.*"

This doesn't change the test message in gdb.sum, but good
to have it.

-- 
Yao (齐尧)