This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 1/3] PR symtab/20652 - fix psymbol_compare

From: Tom Tromey <tom at tromey dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Tue, 04 Oct 2016 12:48:58 -0600
Subject: Re: [RFA 1/3] PR symtab/20652 - fix psymbol_compare
Authentication-results: sourceware.org; auth=none
References: <1475531646-18049-1-git-send-email-tom@tromey.com> <1475531646-18049-2-git-send-email-tom@tromey.com> <ce05875a-71d6-60e3-b194-2c85a0f4a79f@redhat.com>

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> I wonder whether using memcpy is really the correct thing
Pedro> here, considering ginfo.value is a union.  I.e., thinking about
Pedro> padding bits not part of the active member.  Maybe we're zero
Pedro> initializing the whole value and it works in practice because
Pedro> of that.

Yes, psymbols are fully zero-initialized so that they can be entered
into the bcache.  See add_psymbol_to_bcache.

Tom

References:
- [RFA 0/3] Fix various bugs found by static analysis
  - From: Tom Tromey
- [RFA 1/3] PR symtab/20652 - fix psymbol_compare
  - From: Tom Tromey
- Re: [RFA 1/3] PR symtab/20652 - fix psymbol_compare
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]