This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[ping] [PATCH] stack: fix gdb.dwarf2/dw2-undefined-ret-addr.exp regression
- From: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- To: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Cc: "qiyaoltc at gmail dot com" <qiyaoltc at gmail dot com>, "palves at redhat dot com" <palves at redhat dot com>
- Date: Fri, 2 Sep 2016 13:15:56 +0000
- Subject: [ping] [PATCH] stack: fix gdb.dwarf2/dw2-undefined-ret-addr.exp regression
- Authentication-results: sourceware.org; auth=none
ping
Thanks,
Markus.
> -----Original Message-----
> From: Metzger, Markus T
> Sent: Friday, July 22, 2016 1:13 PM
> To: gdb-patches@sourceware.org
> Cc: qiyaoltc@gmail.com; palves@redhat.com
> Subject: [PATCH] stack: fix gdb.dwarf2/dw2-undefined-ret-addr.exp regression
>
> Commit a038fa3e14a4 stack: check frame_unwind_caller_id adds a frame_id
> check to
> frame_info and treats a missing frame_id as NOT_AVAILABLE_ERROR. This
> causes a
> regression in gdb.dwarf2/dw2-undefined-ret-addr.exp.
>
> Treat a missing frame_id as OPTIMIZED_OUT_ERROR instead.
>
> See also https://sourceware.org/ml/gdb-patches/2016-07/msg00273.html.
>
> 2016-07-22 Markus Metzger <markus.t.metzger@intel.com>
>
> gdb/
> * stack.c (frame_info): Call val_print_not_saved instead of
> val_print_unavailable if frame_id check fails.
> ---
> gdb/stack.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/stack.c b/gdb/stack.c
> index b9e74df..9782457 100644
> --- a/gdb/stack.c
> +++ b/gdb/stack.c
> @@ -1508,7 +1508,7 @@ frame_info (char *addr_exp, int from_tty)
> printf_filtered ("saved %s = ", pc_regname);
>
> if (!frame_id_p (frame_unwind_caller_id (fi)))
> - val_print_unavailable (gdb_stdout);
> + val_print_not_saved (gdb_stdout);
> else
> {
> TRY
> --
> 1.8.3.1
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928