This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] Share target_wait prototype between GDB and gdbserver
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Thu, 01 Sep 2016 14:57:58 -0400
- Subject: Re: [PATCH 2/2] Share target_wait prototype between GDB and gdbserver
- Authentication-results: sourceware.org; auth=none
- References: <1472443911-29056-1-git-send-email-sergiodj@redhat.com> <1472443911-29056-3-git-send-email-sergiodj@redhat.com> <49223e65-a30b-7e0e-d545-35799d73b6f7@redhat.com>
On Wednesday, August 31 2016, Pedro Alves wrote:
> On 08/29/2016 05:11 AM, Sergio Durigan Junior wrote:
>
>> --- a/gdb/target.h
>> +++ b/gdb/target.h
>> @@ -1341,18 +1341,6 @@ extern void target_disconnect (const char *, int);
>>
>> extern void target_resume (ptid_t ptid, int step, enum gdb_signal signal);
>>
>> -/* Wait for process pid to do something. PTID = -1 to wait for any
>> - pid to do something. Return pid of child, or -1 in case of error;
>> - store status through argument pointer STATUS. Note that it is
>> - _NOT_ OK to throw_exception() out of target_wait() without popping
>> - the debugging target from the stack; GDB isn't prepared to get back
>> - to the prompt with a debugging target but without the frame cache,
>> - stop_pc, etc., set up. OPTIONS is a bitwise OR of TARGET_W*
>> - options. */
>> -
>> -extern ptid_t target_wait (ptid_t ptid, struct target_waitstatus *status,
>> - int options);
>> -
>
> Please leave a breadcrumb comment here, like was done for
> target_read_memory, for example:
>
> /* For target_read_memory see target/target.h. */
Fixed and pushed:
f2b9e3dfd4bc3c5149496fdbeaa5f0907220685f
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/