This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH V2 4/5] Fortran: Fix query of address of not-allocated types.
- From: Bernhard Heckel <bernhard dot heckel at intel dot com>
- To: qiyaoltc at gmail dot com, eliz at gnu dot org
- Cc: gdb-patches at sourceware dot org, Bernhard Heckel <bernhard dot heckel at intel dot com>
- Date: Mon, 4 Jul 2016 11:52:22 +0200
- Subject: [PATCH V2 4/5] Fortran: Fix query of address of not-allocated types.
- Authentication-results: sourceware.org; auth=none
- References: <1467625943-21294-1-git-send-email-bernhard.heckel@intel.com>
2016-06-30 Bernhard Heckel <bernhard.heckel@intel.com>
gdb/Changelog:
* valops.c (address_of_variable): Throw error on not allocated
types.
gdb/Testsuite/Changelog:
* gdb.fortran/pointers.exp: Dereference temp pointer to a not
allocated array.
* gdb.fortran/vla-value.exp: Adapt expected output.
---
gdb/testsuite/gdb.fortran/pointers.exp | 2 ++
gdb/testsuite/gdb.fortran/vla-value.exp | 2 +-
gdb/valops.c | 3 +++
3 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.fortran/pointers.exp b/gdb/testsuite/gdb.fortran/pointers.exp
index 310544c..df74743 100644
--- a/gdb/testsuite/gdb.fortran/pointers.exp
+++ b/gdb/testsuite/gdb.fortran/pointers.exp
@@ -62,6 +62,8 @@ gdb_test "print \$my_var = intp" "= \\(PTR TO -> \\( $int \\)\\) 0x0"
gdb_breakpoint [gdb_get_line_number "Before value assignment"]
gdb_continue_to_breakpoint "Before value assignment"
gdb_test "print *(twop)%ivla2" "= <not allocated>"
+gdb_test "print *((integer*) &intvla)" "Attempt to take address of a not-allocated type." \
+ "print temporary pointer, not allocated vla"
gdb_breakpoint [gdb_get_line_number "After value assignment"]
diff --git a/gdb/testsuite/gdb.fortran/vla-value.exp b/gdb/testsuite/gdb.fortran/vla-value.exp
index 24f2a9f..7cda0d7 100644
--- a/gdb/testsuite/gdb.fortran/vla-value.exp
+++ b/gdb/testsuite/gdb.fortran/vla-value.exp
@@ -30,7 +30,7 @@ gdb_breakpoint [gdb_get_line_number "vla1-init"]
gdb_continue_to_breakpoint "vla1-init"
gdb_test "print vla1" " = <not allocated>" "print non-allocated vla1"
gdb_test "print &vla1" \
- " = \\\(PTR TO -> \\\( real\\\(kind=4\\\) \\\(:,:,:\\\)\\\)\\\) $hex" \
+ "Attempt to take address of a not-allocated type." \
"print non-allocated &vla1"
gdb_test "print vla1(1,1,1)" "no such vector element \\\(vector not allocated\\\)" \
"print member in non-allocated vla1 (1)"
diff --git a/gdb/valops.c b/gdb/valops.c
index 5ef0c65..0d9b109 100644
--- a/gdb/valops.c
+++ b/gdb/valops.c
@@ -1314,6 +1314,9 @@ address_of_variable (struct symbol *var, const struct block *b)
val = value_of_variable (var, b);
type = value_type (val);
+ if (type_not_allocated (type))
+ error (_("Attempt to take address of a not-allocated type."));
+
if ((VALUE_LVAL (val) == lval_memory && value_lazy (val))
|| TYPE_CODE (type) == TYPE_CODE_FUNC)
{
--
2.7.1.339.g0233b80