This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 3/3] Move logic out of symbol_find_demangled_name
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Fri, 17 Jun 2016 14:50:27 +0100
- Subject: Re: [RFA 3/3] Move logic out of symbol_find_demangled_name
- Authentication-results: sourceware.org; auth=none
- References: <1465051760-25840-1-git-send-email-tom at tromey dot com> <1465051760-25840-4-git-send-email-tom at tromey dot com> <86mvmywgj1 dot fsf at gmail dot com> <8760tl6xbf dot fsf at tromey dot com> <9b062e13-3541-b122-2da8-1c61fe7fe55b at redhat dot com> <871t496nk4 dot fsf at tromey dot com> <7c3ef506-e9f3-968d-c192-c67c99e00269 at redhat dot com> <874m8sp6dh dot fsf at tromey dot com> <9a9f6440-f369-d729-71ff-ea961aac3100 at redhat dot com> <87vb18ngak dot fsf at tromey dot com>
On 06/17/2016 01:36 PM, Tom Tromey wrote:
> Pedro> OK. I still think we should have a comment clarifying this.
> Pedro> The new comment mentions that we'll attempt demangling in the
> Pedro> order the constants are defined, but doesn't explain the
> Pedro> dependencies that led to the particular order you chose.
>
> I added one in language.h but I can move it to enum language instead.
I think I'd prefer it close to where the order is defined.
But maybe there is OK as well; hard to say without seeing.
Maybe do both, and everyone's happy.
As long as we have a comment somewhere discoverable, I'm sure
it'll be fine. So OK however you prefer.
Thanks,
Pedro Alves