This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3][PR gdb/19893] Fix handling of synthetic C++ references
- From: Pedro Alves <palves at redhat dot com>
- To: Martin Galvan <martin dot galvan at tallertechnologies dot com>, gdb-patches at sourceware dot org
- Date: Tue, 31 May 2016 15:23:02 +0100
- Subject: Re: [PATCH v3][PR gdb/19893] Fix handling of synthetic C++ references
- Authentication-results: sourceware.org; auth=none
- References: <20160530194057 dot 13511-1-martin dot galvan at tallertechnologies dot com> <f304ad49-fe80-c7f3-bf4c-71aed85e2429 at redhat dot com>
On 05/31/2016 03:13 PM, Pedro Alves wrote:
> Otherwise OK. Please push.
Actually, I take that back, sorry. I forgot something:
>> + Notice that for references to TYPE_CODE_STRUCT, 'set print object on' will
>> + cause original_value to be a not_lval instead of an lval_computed,
>> + which will make value_bits_synthetic_pointer return false.
I still think it'd be very good to have this covered
with a test.
I think it should be a matter of wrapping the printing
part of new tests (maybe only implref-struct.exp, not sure), with:
foreach_with_prefix print-object {"off" "off"} {
gdb_test_no_output "set print object ${print-object}"
... ref printing tests ...
}
Could you do that please?
Thanks,
Pedro Alves