This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/2] Forward VALUE_LVAL for STRUCT/STRUCT-PTR expressions
- From: Pedro Alves <palves at redhat dot com>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>, gdb-patches at sourceware dot org
- Date: Fri, 27 May 2016 12:39:02 +0100
- Subject: Re: [PATCH 0/2] Forward VALUE_LVAL for STRUCT/STRUCT-PTR expressions
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1464162733 dot git dot andrew dot burgess at embecosm dot com>
On 05/25/2016 09:10 AM, Andrew Burgess wrote:
> These two commits fix some regressions relating to expression
> evaluation involving operations of type STRUCTOP_PTR and
> STRUCTOP_STRUCT.
>
> The regressions were introduced in commit ac1ca910d74d, where values
> with an lval type of not_lval are created in 3 places. A later
> commit, 2520f728b710, fixed one of these places, setting an
> appropriate lval value, but left the other two. These two commits fix
> the last two occurences.
>
> I've split the changes into two patches. The first change is in
> generic expression evaluation, and is covered by the new tests I've
> added in that patch. The tests will also cover the case fixed by
> commit 2520f728b710 as well.
>
> The second patch fixes what I am convinced will be a similar case in
> OpenCL code. However, I don't have access to an OpenCL compiler at
> the moment, so I have not confirmed the bug, nor have I written any
> tests. If the second patch is rejected as untested that's fine, or if
> someone with an OpenCL compiler would like to write a test, that would
> be great.
Both patches are OK.
One nit -- when referring to a git commit hash, please write it
like '... commit 2520f728b710 ($commit-subject) ...' so that we know
what you're talking about without having to go look it up. Please
update the commit logs, and you're good to go.
Thanks,
Pedro Alves