This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 7/8] Use reinsert_breakpoint for vCont;s
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Thu, 26 May 2016 17:52:43 +0100
- Subject: Re: [PATCH 7/8] Use reinsert_breakpoint for vCont;s
- Authentication-results: sourceware.org; auth=none
- References: <1463757161-25850-1-git-send-email-yao dot qi at linaro dot org> <1463757161-25850-8-git-send-email-yao dot qi at linaro dot org> <1fe2e4c5-88c5-e7ec-4d8c-4ba6849ab7ba at redhat dot com>
Pedro Alves <palves@redhat.com> writes:
>> + /* Remove reinsert breakpoints for resume_step. */
>> + if (can_software_single_step ()
>> + && current_thread->last_resume_kind == resume_step
>
> What if a vCont;t came in after the step had started and
> before it finished? Won't we have lost the resume_step
> linux_set_resume_request then?
Do you mean a case like this? GDB sends vCont;s, and then GDBserver
started step-over, in the middle of step-over, GDB sends vCont;t, so
thread->last_resume_kind is set from resume_step to resume_stop, and the
check here fails, so reinsert breakpoints are not deleted.
--
Yao (éå)