This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/8] Pass breakpoint type in set_breakpoint_at
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Tue, 24 May 2016 17:10:23 +0100
- Subject: Re: [PATCH 3/8] Pass breakpoint type in set_breakpoint_at
- Authentication-results: sourceware.org; auth=none
- References: <1463757161-25850-1-git-send-email-yao dot qi at linaro dot org> <1463757161-25850-4-git-send-email-yao dot qi at linaro dot org>
On 05/20/2016 04:12 PM, Yao Qi wrote:
>
> -/* See mem-break.h */
> +/* Set breakpoint of TYPE on address WHERE with handler HANDLER. */
>
> -struct breakpoint *
> -set_breakpoint_at (CORE_ADDR where, int (*handler) (CORE_ADDR))
> +static struct breakpoint *
> +set_breakpoint_at_1 (enum bkpt_type type, CORE_ADDR where,
> + int (*handler) (CORE_ADDR))
Maybe avoid the bland "_1", like:
set_breakpoint_type_at (enum bkpt_type type, CORE_ADDR where,
int (*handler) (CORE_ADDR))
But LGTM.
Thanks,
Pedro Alves