This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] ftrace: Fix gdbserver crash when doing tstatus after detach or process exit


On 16-04-28 01:04 PM, Simon Marchi wrote:
>> +# Check that the target supports trace.
>> +if { [gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $options] != "" } {

I just saw that I used gdb_compile_pthreads.  As Yao mentioned in another thread,
it should be gdb_compile instead.

>> +    untested "Couldn't compile test program"
>> +    return -1
>> +}
>> +
>> +clean_restart ${testfile}
>> +
>> +if ![runto_main] {
>> +    fail "Can't run to main to check for trace support"
>> +    return -1
>> +}
>> +
>> +if $use_gdb_stub {
>> +    # This test is about testing commands after detaching from a process or
>> +    # after letting a process exit, so it doesn't make sense to run it if the
>> +    # target is stub-like.
>> +    unsupported "This test is not supported for GDB stub targets."
>> +    return -1
>> +}
>> +
>> +if ![gdb_target_supports_trace] {
>> +    unsupported "target does not support trace"
>> +    return -1
>> +}
>> +
>> +# Compile the test case with the in-process agent library.
>> +set libipa [get_in_proc_agent]
>> +gdb_load_shlibs $libipa
>> +
>> +lappend options shlib=$libipa
>> +
>> +if { [gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $options] != "" } {

Same here.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]