This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] python: Use console format for output of gdb.execute command
- From: Pedro Alves <palves at redhat dot com>
- To: Catalin Udma <catalin dot udma at freescale dot com>, gdb-patches at sourceware dot org
- Date: Thu, 31 Mar 2016 13:00:36 +0100
- Subject: Re: [PATCH v2] python: Use console format for output of gdb.execute command
- Authentication-results: sourceware.org; auth=none
- References: <1459420984-6582-1-git-send-email-catalin dot udma at freescale dot com>
On 03/31/2016 11:43 AM, Catalin Udma wrote:
> When gdb is started in MI mode, the output of gdb.execute
> command is in MI-format in case when it is executed from python stop
> handler while for all other cases the output is in console-format.
>
> To assure consistent output format, this is fixed by using the console
> format for all python gdb command executions.
>
> PR python/19743
>
> gdb/ChangeLog:
> 2016-03-31 Catalin Udma <catalin.udma@freescale.com>
>
> PR python/19743
> * python/python.c (execute_gdb_command): Use console uiout
> when executing gdb command.
> * utils.c (restore_ui_out_closure): New structure.
> (do_restore_ui_out): New function.
> (make_cleanup_restore_ui_out): Likewise.
> * utils.h (make_cleanup_restore_ui_out): Declare.
>
> gdb/testsuite/ChangeLog:
> 2016-03-31 Catalin Udma <catalin.udma@freescale.com>
>
> PR python/19743
> * gdb.python/py-mi-events-gdb.py: New file.
> * gdb.python/py-mi-events.c: New file.
> * gdb.python/py-mi-events.exp: New file.
>
> Signed-off-by: Catalin Udma <catalin.udma@freescale.com>
> ---
>
> Changes for v2:
> * add a cleanup restore for struct ui_out
> * restore current_ui_out with a cleanup
> * test python file: use assert for both stop and continue handlers
> * don't use test that runs forever
OK.
Thanks,
Pedro Alves