This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v4] gdbserver/s390: Switch on tracepoint support.


On 29/03/16 20:30, Ulrich Weigand wrote:
Marcin Kościelnicki wrote:
On 23/03/16 16:25, Andreas Arnez wrote:
On Tue, Mar 15 2016, Marcin Kościelnicki wrote:

Also adds s390 support to gdb.trace testsuite.

gdb/gdbserver/ChangeLog:

	* linux-s390-low.c (s390_supports_tracepoints): New function.
	(struct linux_target_ops): Fill supports_tracepoints hook.

gdb/testsuite/ChangeLog:

	* gdb.trace/ftrace.exp: Set arg0exp for s390.
	* gdb.trace/mi-trace-frame-collected.exp: Expect 4 registers on s390.
	* gdb.trace/mi-trace-unavailable.exp: Set pcnum for s390, add gpr0num
	variable for GPR 0 instead of assuming it is register 0.
	* gdb.trace/trace-common.h: Add s390 fast tracepoint placeholder.
	* lib/trace-support.exp: Add s390 registers.
---
This fixes a minor conflict with the powerpc regular tracepoint support
pushed in the meantime (mi-trace-unavailable.exp now needs gpr0num in
powerpc branch).

Please also document this new feature in the NEWS file.

OK, I'll submit another patch adding the NEWS entry (it should go after
the fast tracepoints).

Otherwise the patch looks good to me.  But I think a global- or
testsuite-maintainer should approve the changes to the testsuite.

Those changes are OK.

Thanks,
Ulrich


Thanks, pushed.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]