This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 12/30] Don't call clear_quit_flag in command_handler
- From: Pedro Alves <palves at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Fri, 18 Mar 2016 19:18:16 +0000
- Subject: [PATCH 12/30] Don't call clear_quit_flag in command_handler
- Authentication-results: sourceware.org; auth=none
- References: <1458328714-4938-1-git-send-email-palves at redhat dot com>
This just looks totally wrong to me, for completetly discarding a
user-requested Ctrl-C. I can't think of why we'd want do this here.
Actually, I digged the history, and found out that this has been here
since at least 7b4ac7e1ed2c (gdb-2.4, the initial revision, 1988), at
a time were we had a top level setjmp/longjmp, long before that got
wrapped in throw_exception and friends, and this code was in an
explicit loop, with the quit_flag cleared on every iteration, before
executing a command...
gdb/ChangeLog:
yyyy-mm-dd Pedro Alves <palves@redhat.com>
* event-top.c (command_handler): Don't call clear_quit_flag.
---
gdb/event-top.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/gdb/event-top.c b/gdb/event-top.c
index da72b1d..7fedb48 100644
--- a/gdb/event-top.c
+++ b/gdb/event-top.c
@@ -459,7 +459,6 @@ command_handler (char *command)
struct cleanup *stat_chain;
char *c;
- clear_quit_flag ();
if (instream == stdin)
reinitialize_more_filter ();
--
2.5.0