This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH V5 2/2] Add mpx-bnd-init-on-return set/show command for inferior calls.
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Walfred Tedeschi <walfred dot tedeschi at intel dot com>
- Cc: palves at redhat dot com, brobecker at adacore dot com, gdb-patches at sourceware dot org
- Date: Fri, 18 Mar 2016 17:11:39 +0200
- Subject: Re: [PATCH V5 2/2] Add mpx-bnd-init-on-return set/show command for inferior calls.
- Authentication-results: sourceware.org; auth=none
- References: <1458310577-20021-1-git-send-email-walfred dot tedeschi at intel dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Walfred Tedeschi <walfred.tedeschi@intel.com>
> Cc: gdb-patches@sourceware.org, Walfred Tedeschi <walfred.tedeschi@intel.com>
> Date: Fri, 18 Mar 2016 15:16:17 +0100
>
> diff --git a/gdb/NEWS b/gdb/NEWS
> index be15902..a123f7d 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -27,6 +27,11 @@ skip -rfunction regular-expression
> glob-style file names and regular expressions for function names.
> Additionally, a file spec and a function spec may now be combined.
>
> +show mpx-bnd-init-on-return
> +set mpx-bnd-init-on-return on i386 and amd64
> + In case MPX-BND-INIT-ON-RETURN is true, bound registers
> + will be initialized when the "return" command is used.
> +
We don't up-case the option names in NEWS. Also, the "on i386 and
amd64" part is not really part of the command, is it?
So I suggest the following minor change to the wording:
show mpx-bnd-init-on-return
set mpx-bnd-init-on-return on i386 and amd64
On i386 and amd64, if this option is ON, bound registers
will be re-initialized when the "return" command is used.
> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 4ec0ec1..0e8531a 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
This part is okay.
Thanks.