This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH, doc RFA] Add "skip regexp"
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Doug Evans <dje at google dot com>
- Cc: Pedro Alves <palves at redhat dot com>, <eliz at gnu dot org>, <gdb-patches at sourceware dot org>
- Date: Thu, 3 Mar 2016 15:40:48 -0500
- Subject: Re: [PATCH, doc RFA] Add "skip regexp"
- Authentication-results: sourceware.org; auth=none
- References: <047d7b15faa92d0dac052d29e927 at google dot com>
On 16-03-03 02:21 PM, Doug Evans wrote:
> 2016-03-03 Doug Evans <dje@google.com>
>
> * gdb.base/skip.c (main): Call test_skip_file_and_function.
> * gdb.base/skip.exp: Remove hand calling test_skip_file_and_function.
>
> diff --git a/gdb/testsuite/gdb.base/skip.c b/gdb/testsuite/gdb.base/skip.c
> index b9db2a7..e43da1e 100644
> --- a/gdb/testsuite/gdb.base/skip.c
> +++ b/gdb/testsuite/gdb.base/skip.c
> @@ -25,8 +25,14 @@ void skip1_test_skip_file_and_function (void);
> int
> main ()
> {
> + int x;
> +
> /* Use comma operator to sequence evaluation of bar and foo. */
> - return baz ((bar (), foo ()));
> + x = baz ((bar (), foo ()));
> +
> + test_skip_file_and_function ();
This function should be forward-declared.
Otherwise, it LGTM. I tested it on the target that reported the problem initially,
and it's now 100% pass.
Thank you very much!