This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/3] gdb.trace: Surround $call_insn with \y in entry-values.exp

From: Marcin KoÅcielnicki <koriakin at 0x04 dot net>
To: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
Cc: antoine dot tremblay at ericsson dot com
Date: Thu, 25 Feb 2016 16:12:34 +0100
Subject: Re: [PATCH 2/3] gdb.trace: Surround $call_insn with \y in entry-values.exp
Authentication-results: sourceware.org; auth=none
References: <56C7323C dot 4050707 at 0x04 dot net> <1455976932-22255-1-git-send-email-koriakin at 0x04 dot net> <1455976932-22255-2-git-send-email-koriakin at 0x04 dot net> <56CF0D78 dot 8080003 at redhat dot com>

On 25/02/16 15:19, Pedro Alves wrote:

On 02/20/2016 02:02 PM, Marcin KoÅcielnicki wrote:

The PPC64 tracepoint patch added \y at the end of the call_insn pattern -
without that, it embarassed itself and matched the 'bl' in "Dump of
assem*bl*er code for function" as the powerpc call opcode.  Since that
sounds like a generally good idea, I've added \y before and after
call_insn for every target.  As a result, I had to change x86_64's mnemonic
to 'callq'.


OK.

Thanks,
Pedro Alves


Thanks, pushed.

References:
- Re: [PATCH] gdb.trace: Move more target dependencies to trace-support.exp
  - From: Marcin KoÅcielnicki
- [PATCH 1/3] gdb.trace: Move more target dependencies to trace-support.exp
  - From: Marcin KoÅcielnicki
- [PATCH 2/3] gdb.trace: Surround $call_insn with \y in entry-values.exp
  - From: Marcin KoÅcielnicki
- Re: [PATCH 2/3] gdb.trace: Surround $call_insn with \y in entry-values.exp
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]