This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 01/11] [PR gdb/14441] gdb: gdbtypes: add definitions for rvalue reference type
- From: Artemiy Volkov <artemiyv at acm dot org>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 24 Feb 2016 17:31:25 -0800
- Subject: Re: [PATCH v2 01/11] [PR gdb/14441] gdb: gdbtypes: add definitions for rvalue reference type
- Authentication-results: sourceware.org; auth=none
- References: <1450661481-31178-1-git-send-email-artemiyv at acm dot org> <1453229609-20159-1-git-send-email-artemiyv at acm dot org> <1453229609-20159-2-git-send-email-artemiyv at acm dot org> <56C763C2 dot 8090207 at redhat dot com> <20160223070313 dot GA1564 at gmail dot com> <56CE574A dot 2000406 at redhat dot com>
On Wed, Feb 24, 2016 at 05:22:18PM -0800, Keith Seitz wrote:
> On 02/22/2016 11:03 PM, Artemiy Volkov wrote:
> > On Fri, Feb 19, 2016 at 10:49:38AM -0800, Keith Seitz wrote:
> >
> > Do you suggest keeping only the lvalue version of the reference type and
> > then adjust its type code from TYPE_CODE_REF to TYPE_CODE_RVALUE_REF on
> > lookup_rvalue_reference_type()? It seems somewhat hacky to me. E.g. how
> > would we be able to create a struct type for a complex type involving a
> > T&&, such as a typedef of it?
>
> Bah. No, I am wrong. Please disregard this comment.
>
> Sorry about the confusion.
No problem at all. Correct me if I am wrong, but I think this
invalidates your remarks in 2/11 that refer to this change. Do those 2
hunks in 2/11 look OK now?
>
> Keith
Thanks,
Artemiy