This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb: Add guess_tracepoint_registers hook to gdbarch.
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: koriakin at 0x04 dot net (Marcin KoÅcielnicki)
- Cc: lgustavo at codesourcery dot com, arnez at linux dot vnet dot ibm dot com, gdb-patches at sourceware dot org
- Date: Thu, 18 Feb 2016 16:58:43 +0100 (CET)
- Subject: Re: [PATCH] gdb: Add guess_tracepoint_registers hook to gdbarch.
- Authentication-results: sourceware.org; auth=none
Marcin KoÅ?cielnicki wrote:
> On 18/02/16 16:40, Ulrich Weigand wrote:
> > I don't think you actually need this include, do you?
> >
> > Otherwise, this patch is OK.
> >
> > Bye,
> > Ulrich
> >
>
> I do, the default_guess_tracepoint_registers function is declared there,
> and gdbarch.c uses it.
Ah, right. You should probably move the prototype to arch-utils.h
(and then the implementation to arch-utils.c) to go with the other
default_ functions.
Since gdbarch.h is included everywhere, we try to avoid having it
include other headers as far as possible.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com