This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb: Add guess_tracepoint_registers hook to gdbarch.
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: koriakin at 0x04 dot net (Marcin KoÅcielnicki)
- Cc: lgustavo at codesourcery dot com, arnez at linux dot vnet dot ibm dot com, gdb-patches at sourceware dot org, koriakin at 0x04 dot net (Marcin KoÅcielnicki)
- Date: Thu, 18 Feb 2016 16:40:28 +0100 (CET)
- Subject: Re: [PATCH] gdb: Add guess_tracepoint_registers hook to gdbarch.
- Authentication-results: sourceware.org; auth=none
Marcin KoÅ?cielnicki wrote:
> * gdbarch.c: Regenerate.
> * gdbarch.h: Regenerate.
> * gdbarch.sh: Add guess_tracepoint_registers hook, include
> tracepoint.h.
> * tracefile.c (tracefile_fetch_registers): Use the new gdbarch hook.
> * tracepoint.c (default_guess_tracepoint_registers): New function.
> * tracepoint.h (default_guess_tracepoint_registers): New prototype.
> #include "observer.h"
> #include "regcache.h"
> #include "objfiles.h"
> +#include "tracepoint.h"
I don't think you actually need this include, do you?
Otherwise, this patch is OK.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com