This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix 19548: Breakpoint re-set inserts breakpoints when it shouldn't


I pushed this in now, with a tiny change to a comment:

On 02/01/2016 05:04 PM, Pedro Alves wrote:

> -    # On a buggy GDB, with always-inserted on, we'd see:
> +    # Set a second breakpoint (whose original address also ends up
> +    # unmmapped after the exec), for PR 19548.
> +    gdb_test "break some_function" "Breakpoint .*"
> +
> +    # PR17431: with always-inserted on, we'd see:
>      #  (gdb) continue
>      #  Continuing.
>      #  Warning:
>      #  Cannot insert breakpoint 1.
>      #  Cannot access memory at address 0x10000ff
> -    gdb_test "continue" "Breakpoint 1, main.*" "continue across exec"
> +
> +    # PR 19548: with more than one breakpoint, we'd see:
> +    #  (gdb) continue
> +    #  Continuing.
> +    #  process 17227 is executing new program: (...)/execl-update-breakpoints2

Looking at the diff again, I noticed this "17227" here looks confusingly similar
to the PRs listed, so I replaced it with "(...)".

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]