This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [obv. PATCH 1/1] Fix build breakage
- From: Pedro Alves <palves at redhat dot com>
- To: "Tedeschi, Walfred" <walfred dot tedeschi at intel dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 09 Feb 2016 10:55:11 +0000
- Subject: Re: [obv. PATCH 1/1] Fix build breakage
- Authentication-results: sourceware.org; auth=none
- References: <1455013458-14340-1-git-send-email-walfred dot tedeschi at intel dot com> <56B9BFF3 dot 7020905 at redhat dot com> <AC542571535E904D8E8ADAE745D60B194453709B at IRSMSX104 dot ger dot corp dot intel dot com> <56B9C455 dot 7040803 at redhat dot com>
On 02/09/2016 10:49 AM, Pedro Alves wrote:
> On 02/09/2016 10:37 AM, Tedeschi, Walfred wrote:
>> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Pedro Alves
>
>> How is this better than what Simon proposed?
>
>> I haven't seem Simon's proposal, have just feel sorry to have caused this breakage, and tried to fix.
>> Just noticed that with the e-mail from Sergio this early morning.
>
> Simon's fix was quoted in Sergio's e-mail. :-)
>
>> I will revert what I just pushed,
>
> You reverted one patch unrelated patch too:
>
> commit 0635c8759326e9431604b3359185cbf96740521d
> Author: Walfred Tedeschi <walfred.tedeschi@intel.com>
>
> Revert "Add a more helpful warning message to explain why some AArch64 relocations can overflow."
>
> This reverts commit 2ea53e003163338a403d5afbb2046cafb8f3abe9.
>
> I've reapplied 2ea53e003163 now, preserving the original author (for "git blame").
>
>
> BTW, given you first fixed the C++ build, and then broke it again with
> the revert, you should have gotten another e-mail from the buildbot
> about C++ build breakage. Can you confirm whether you got one this time?
Actually, the builder hasn't moved on past your reversion, we'll need to
wait a few minutes more to check that.
http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cxx-build-m64
Pending Build Requests:
(Feb 09 05:39:21, waiting 13 mins, 5 secs) c23bbc1cdae6... (Walfred Tedeschi <walfred.tedeschi@intel.com>)
Thanks,
Pedro Alves