This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] varobj: Cleanup dead code
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Simon Marchi <simon dot marchi at polymtl dot ca>
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 7 Feb 2016 16:56:29 +0400
- Subject: Re: [PATCH] varobj: Cleanup dead code
- Authentication-results: sourceware.org; auth=none
- References: <1454300223-10407-1-git-send-email-simon dot marchi at polymtl dot ca>
> I also moved the function comment to the header file to comply with
> today's guideline, even though the rest of the file does not respect it
> (yet).
FTR: There is actually no real agreement on this, and because each
approach has its advantages, short of a royal edict, we'll probably
continue accepting both forms.
> gdb/ChangeLog:
>
> * varobj.h (varobj_delete): Remove dellist parameter, update and
> move documentation here.
> * varobj.c (struct cpstack, cppush, cppop): Remove.
> (delete_variable): Remove resultp (first) parameter.
> (delete_variable_1): Likewise.
> (varobj_delete): Remove dellist parameter and unused code.
> (update_dynamic_varobj_children): Adjust varobj_delete call.
> (update_type_if_necessary): Likewise.
> (varobj_set_visualizer): Likewise.
> (varobj_update): Likewise.
> (value_of_root): Likewise.
> (varobj_invalidate_iter): Likewise.
> * mi/mi-cmd-var.c (mi_cmd_var_delete): Likewise.
Looks good to me.
Thanks for doing that cleanup.
--
Joel