This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] gdb.trace/testsuite: Bump stack collection fudge factor.
- From: Marcin KoÅcielnicki <koriakin at 0x04 dot net>
- To: gdb-patches at sourceware dot org
- Cc: Marcin KoÅcielnicki <koriakin at 0x04 dot net>
- Date: Sat, 23 Jan 2016 15:49:47 +0100
- Subject: [PATCH] gdb.trace/testsuite: Bump stack collection fudge factor.
- Authentication-results: sourceware.org; auth=none
These two tests collect 64 words from $sp onwards, hoping that's enough
to capture a few whole stack frames. Unfortunately, that's not enough
for s390, which tends to have large frame sizes - minimum 24 words on
s390, 20 on s390x (which just barely passes). Bump it to 128 words,
let's hope no machine needs more.
Tested on x86_64, s390, s390x.
gdb/testsuite/ChangeLog:
* gdb.trace/backtrace.exp: Bump stack collection fudge factor.
* gdb.trace/entry-values.exp: Bump stack collection fudge factor.
---
gdb/testsuite/ChangeLog | 5 +++++
gdb/testsuite/gdb.trace/backtrace.exp | 2 +-
gdb/testsuite/gdb.trace/entry-values.exp | 2 +-
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 8ee2efa..a201b66 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,10 @@
2016-01-23 Marcin KoÅcielnicki <koriakin@0x04.net>
+ * gdb.trace/backtrace.exp: Bump stack collection fudge factor.
+ * gdb.trace/entry-values.exp: Bump stack collection fudge factor.
+
+2016-01-23 Marcin KoÅcielnicki <koriakin@0x04.net>
+
* gdb.trace/unavailable-dwarf-piece.exp: Fix bitfield handling on big
endian targets.
diff --git a/gdb/testsuite/gdb.trace/backtrace.exp b/gdb/testsuite/gdb.trace/backtrace.exp
index ad18f15..881a798 100644
--- a/gdb/testsuite/gdb.trace/backtrace.exp
+++ b/gdb/testsuite/gdb.trace/backtrace.exp
@@ -142,7 +142,7 @@ gdb_trace_setactions "8.6: setup TP to collect regs, args, and locals" \
gdb_trace_setactions "8.6: setup TP to collect stack mem cast expr" \
"$tdp6" \
- "collect \$$fpreg, \(\*\(void \*\*\) \(\$$spreg\)\) @ 64" "^$"
+ "collect \$$fpreg, \(\*\(void \*\*\) \(\$$spreg\)\) @ 128" "^$"
gdb_test_no_output "tstart" ""
diff --git a/gdb/testsuite/gdb.trace/entry-values.exp b/gdb/testsuite/gdb.trace/entry-values.exp
index 7f60b8c..825928d 100644
--- a/gdb/testsuite/gdb.trace/entry-values.exp
+++ b/gdb/testsuite/gdb.trace/entry-values.exp
@@ -219,7 +219,7 @@ gdb_test "trace foo" "Tracepoint $decimal at .*"
# argument j.
gdb_trace_setactions "set action for tracepoint 1" "" \
- "collect i, j, global1, \(\*\(void \*\*\) \(\$$spreg\)\) @ 64" "^$"
+ "collect i, j, global1, \(\*\(void \*\*\) \(\$$spreg\)\) @ 128" "^$"
gdb_test_no_output "tstart"
--
2.7.0