Re: [PATCH] gdb.trace: Fix unavailable-dwarf-piece.exp on big endian targets

[Marcin KoÅcielnicki <koriakin at 0x04 dot net>]

On 23/01/16 14:22, Pedro Alves wrote:
> On 01/23/2016 12:34 PM, Marcin KoÅcielnicki wrote:
>
> > diff --git a/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp b/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp
> > index 60820dd..e511915 100644
> > --- a/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp
> > +++ b/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp
> > @@ -325,10 +325,23 @@ with_test_prefix "tracing bar" {
> >       gdb_test "continue" "Continuing\\.\[ \r\n\]+Breakpoint.*"
> >       gdb_test_no_output "tstop"
> >
> > +    gdb_test_multiple "show endian" "show endian" {
> > +	-re ".* (big|little) endian.*$gdb_prompt $" {
> > +	    set endian $expect_out(1,string)
> > +	    pass "endianness: $endian"
> > +	}
> > +    }
>
> Do:
>
>      set endian ""
>      gdb_test_multiple "show endian" "show endian" {
>      ...
>
> Otherwise if that gdb_test_multiple fails, $endian doesn't exist,
> and the if below throws a tcl error.
>
> OK with that change.

Thanks, fixed and pushed.