This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] testsuite: Make check-parallel return non-zero if a test failed
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Tue, 19 Jan 2016 11:15:41 +0000
- Subject: Re: [PATCH] testsuite: Make check-parallel return non-zero if a test failed
- Authentication-results: sourceware.org; auth=none
- References: <1453157331-5472-1-git-send-email-simon dot marchi at ericsson dot com>
On 01/18/2016 10:48 PM, Simon Marchi wrote:
> When using the check-parallel target, the return code of make is always 0,
> regardless of test results. This patch makes it return the same code as
> the "make do-check-parallel" sub-command. So if there is a FAIL somewhere,
> non-zero will be returned by make.
>
> For the sake of example, I introduced a failure in gdb.base/break.exp.
>
> $ make check-single TESTS="gdb.base/break.exp gdb.python/py-value.exp" && echo 'Success :D' || echo 'Fail :('
> ...
> FAIL: gdb.base/break.exp: allo
> ...
> Fail :(
>
> I think the parallel run should do the same. Currently:
>
> $ make check-parallel TESTS="gdb.base/break.exp gdb.python/py-value.exp" && echo 'Success :D' || echo 'Fail :('
> ...
> FAIL: gdb.base/break.exp: allo
> ...
> Success :D
>
> And with the patch (no big surprises there):
>
> $ make check-parallel TESTS="gdb.base/break.exp gdb.python/py-value.exp" && echo 'Success :D' || echo 'Fail :('
> ...
> FAIL: gdb.base/break.exp: allo
> ...
> Fail :(
>
> What do you think?
This has occasionally annoyed me too. Thanks for fixing this!
LGTM.
Thanks,
Pedro Alves