This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 0/2] Remove argument pc in get_next_pcs




On 01/15/2016 04:57 AM, Yao Qi wrote:
Hi,
get_next_pcs in struct linux_target_ops has two arguments, PC and
REGCACHE.  Since PC can be got from REGCACHE, PC is redundant, so this
patch series remove it in various places.  After the removal, PC is
got from regcache via regcache_read_pc, so patch #1 uses
regcache_read_pc out of *the_low_target.get_next_pcs.  Then, patch #2
removes PC arguments and PC can be got inside the implementations of
get_next_pcs via regcache_read_pc.

Regression tested on arm-linux.

*** BLURB HERE ***

Yao Qi (2):
   [GDBserver] Use regcache_read_pc in
     install_software_single_step_breakpoints
   Remove argument pc in get_next_pcs

  gdb/arch/arm-get-next-pcs.c   | 24 +++++++++++++-----------
  gdb/arch/arm-get-next-pcs.h   |  3 +--
  gdb/arm-linux-tdep.c          |  2 +-
  gdb/arm-tdep.c                |  2 +-
  gdb/gdbserver/linux-arm-low.c |  4 ++--
  gdb/gdbserver/linux-low.c     |  3 +--
  gdb/gdbserver/linux-low.h     |  2 +-
  7 files changed, 20 insertions(+), 20 deletions(-)


LGTM, thanks for the patches.

Regards,
Antoine


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]