This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] sim: allow the inline configure option everywhere [committed]


On 12 Jan 2016 13:47, Steve Ellcey wrote:
> On Sun, 2016-01-10 at 03:40 -0500, Mike Frysinger wrote:
> > Currently ports have to call SIM_AC_OPTION_INLINE explicitly in order
> > to make the configure flag available.  There's no real reason to not
> > allow this flag for all ports, so move it to the common sim macro.
> > This way we get standard behavior across all ports too.
> 
> Before this patch was checked in (commit
> 347fe5bb868b7383d4f6942894b31ecf1da6894e), when I built all-gdb for the
> target mips-mti-linux-gnu, sim was not built.  After the change, it does
> get built

i'm fairly certain that is not the case.  that commit did not change the
top level or the common sim configure at all, and the mips-specific change
did not impact whether it was built.

> (well, it tries to get built, it actually fails to build).

that is a bug in the sim introduced by commit 8e394ffc7ab691eafcf276d7ae.
i filed a bug for it here:
https://sourceware.org/bugzilla/show_bug.cgi?id=19441

> I am not sure if this change in behavior, trying to build sim,  is
> intended or not.  I can fix it easily enough by using --disable-sim on
> my configure but I just wanted to check to see if this change was
> intentional.  I have never built sim for this target before because I
> use qemu for testing it.  I only use GNU sim for testing the mips*elf
> targets.

when building for mips*, you've always had to use --disable-sim in order
to keep it from being built.
-mike

Attachment: signature.asc
Description: Digital signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]