This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb.base/async.exp: Handle "asynchronous execution not supported"
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Kevin Buettner <kevinb at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 8 Dec 2015 09:01:24 +0100
- Subject: Re: [PATCH] gdb.base/async.exp: Handle "asynchronous execution not supported"
- Authentication-results: sourceware.org; auth=none
- References: <20151207232255 dot 15b0c35e at pinnacle dot lan>
Hi Kevin,
> gdb/testsuite/ChangeLog:
>
> * gdb.base/async.exp (proc test_background): Add case
> for asynchronous execution not supported.
You might want to escape the period you're trying to match
at the end of the sentence. Other than that, LGTM.
Looking at this, would it be possible in this case to replace
the send_gdb/gdb_expect into test_gdb_multiple? I'm not really
sure, because of the async nature makes ordering of the output
relative to the gdb_prompt different from usual, and thus perhaps
outside the scope of what test_gdb_multiple is capable of doing...
Thanks!
> ---
> gdb/testsuite/gdb.base/async.exp | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/gdb/testsuite/gdb.base/async.exp b/gdb/testsuite/gdb.base/async.exp
> index 2d3fb73..8226244 100644
> --- a/gdb/testsuite/gdb.base/async.exp
> +++ b/gdb/testsuite/gdb.base/async.exp
> @@ -61,6 +61,9 @@ proc test_background {command before_prompt after_prompt {message ""}} {
> -re "$gdb_prompt.*completed\.\r\n" {
> fail "$message"
> }
> + -re ".*Asynchronous execution not supported on this target..*" {
> + unsupported "Asynchronous execution not supported: $message"
> + }
> timeout {
> fail "$message (timeout)"
> }
--
Joel