This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3 04/10] Remove support for thread events without PTRACE_EVENT_CLONE in GDBServer.




On 11/25/2015 11:48 AM, Yao Qi wrote:
Antoine Tremblay <antoine.tremblay@ericsson.com> writes:

---
  gdb/gdbserver/linux-low.c |   2 +-
  gdb/gdbserver/linux-low.h |   2 +-
  gdb/gdbserver/thread-db.c | 153 ++--------------------------------------------
  3 files changed, 6 insertions(+), 151 deletions(-)

diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
index f793a78..ce9cc2e 100644
--- a/gdb/gdbserver/linux-low.c
+++ b/gdb/gdbserver/linux-low.c
@@ -5515,7 +5515,7 @@ linux_look_up_symbols (void)
    /* If the kernel supports tracing clones, then we don't need to
       use the magic thread event breakpoint to learn about
       threads.  */

Nit: we no longer need this comment above.  We can remove it too.


Indeed, fixed.

-  thread_db_init (!linux_supports_traceclone ());
+  thread_db_init ();

Patch looks good to me.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]